-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing: fix test command #4482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
Contributing.md
Outdated
@@ -110,7 +110,7 @@ You can run these tests yourself with | |||
`nox -s clippy-all` | |||
|
|||
#### Tests | |||
`cargo test --features full` | |||
`nox -s test` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it potentially worth mentioning both options here? I tend to use cargo test
to selectively run the ones I care about (and it's much quicker), though I agree most contributors would benefit from having this recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also nox -s test-rust
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes, for running a specific test cargo test
is probably still best, I'll add a sentence.
Oh, and for adding a hint how to run Rust tests, is there a way to run a specific test from pytests
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cd pytests && nox -s test -- -k <test>
(the -k
switch goes to underlying pytest
execution)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or nox -f pytests/noxfile.py -s test -- -k <test>
to avoid the cd
.
Only "cargo test" does not run Python tests.
e18782e
to
cd39179
Compare
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Only "cargo test" does not run Python tests.